Remove image upload description

[jamuc]

Fixes #1527

What this does

• Remove the description text field
• When a title is set, use it as alt text
• When return on keyboard is tapped, close keyboard
• Increase size of image view

[jamuc]

Side note, could also remove the white spaces above and below the image

[BasThomas]

Side note, could also remove the white spaces above and below the image

That would be nice, I think. And then just leave the white spaces in case of a vertical image? Or maybe use the background color?

[rnystrom]

I think the white exists because it’s a grouped table view. Otherwise you see the separators awkwardly.

Honestly could probably just remove the table view entirely, it’s a very simple view.

I’m almost more in favor of killing this view entirely.

• Check if we can upload images
• Show the picker
• Upload after you select an image

Something to think about

_{Sent with GitHawk}

[jamuc]

@rnystrom You mean you wouldn't bother even allowing the user to set a title?

[rnystrom]

@jamuc nope, I'd rather edit the image alt text myself in the markdown

[SD10]

There is a ton of wasted space here. I think a picker would look much better. Maybe we could even do something like display a collection view/picker under the text input bar (like slack)

_{Sent with GitHawk}

[rnystrom]

@SD10 that’d be ideal, tho we don’t need to block this PR on it. I’d love to bake that into MessageViewController if possible!

_{Sent with GitHawk}

[SD10]

Totally agree @rnystrom. Is your double message related to you playing around with airplane mode?

[rnystrom]

That might have actually been some sort of bug. I got an error in app and resent it. Didn’t realize it sent twice! 😱

_{Sent with GitHawk}