Skip to content
This repository was archived by the owner on Sep 20, 2023. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions Classes/People/PeopleViewController.swift
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,17 @@ PeopleSectionControllerDelegate {
return false
}
}


static func sortUsers(users: [V3User], currentUser: String?) -> [V3User] {
return users.sorted {
if $0.login == currentUser {
return true
} else {
return $0.login.caseInsensitiveCompare($1.login) == .orderedAscending
}
}
}

// MARK: Private API

func updateSelectionCount() {
Expand All @@ -106,9 +116,10 @@ PeopleSectionControllerDelegate {
) { [weak self] result in
switch result {
case .success(let response):
let sortedUsers = response.data.sorted {
$0.login.caseInsensitiveCompare($1.login) == .orderedAscending
}
let sortedUsers = PeopleViewController.sortUsers(
users: response.data,
currentUser: self?.client.userSession?.username
)
let users = sortedUsers.map { IssueAssigneeViewModel(login: $0.login, avatarURL: $0.avatarUrl) }
if page != nil {
self?.users += users
Expand Down
52 changes: 52 additions & 0 deletions FreetimeTests/SortUsers.swift
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
//
// SortUsers.swift
// FreetimeTests
//
// Created by B_Litwin on 10/8/18.
// Copyright © 2018 Ryan Nystrom. All rights reserved.
//

import XCTest
@testable import Freetime
@testable import GitHubAPI

class SortUsers: XCTestCase {

func makeUser(_ name: String) -> V3User {
return V3User(
avatarUrl: URL(string: "github.com")!,
id: 1,
login: name,
siteAdmin: false,
type: .user
)
}

func test_SortWithCurrentUserFirst() {

var users = [
"A_rnystrom",
"B_basthomas",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😁

"C_Sherlouk",
].map(makeUser)

var sorted = PeopleViewController.sortUsers(
users: users,
currentUser: "B_basthomas"
)

// sorts the current user first and otherwise sorts alphabetically
XCTAssertEqual(sorted[0].login, "B_basthomas")
XCTAssertEqual(sorted[1].login, "A_rnystrom")
XCTAssertEqual(sorted[2].login, "C_Sherlouk")

sorted = PeopleViewController.sortUsers(
users: users,
currentUser: nil
)

XCTAssertEqual(sorted[0].login, "A_rnystrom")
XCTAssertEqual(sorted[1].login, "B_basthomas")
XCTAssertEqual(sorted[2].login, "C_Sherlouk")
}
}