Changing request review message to self when the same user #2558
Conversation
|
|
||
| let styledString: StyledTextString | ||
| if actor == user { | ||
| styledString = IssueRequestModel.buildSelfString(actor: actor, |
There was a problem hiding this comment.
nit: newline this like
buildSelfString(
actor: actor,
...
)
| date: date, | ||
| event: event) | ||
| } else { | ||
| styledString = IssueRequestModel.buildString(actor: actor, |
| ).warm(width: width) | ||
| } | ||
|
|
||
| static private func buildSelfString(actor: String, |
There was a problem hiding this comment.
newline this (same as above)
function(
param1: ...,
param2 ...,
) -> return {
| return builder.build() | ||
| } | ||
|
|
||
| static private func buildString(actor: String, |
| } | ||
|
|
||
| static private func buildSelfString(actor: String, | ||
| user: String, |
There was a problem hiding this comment.
user is never used inside this function so no need to pass it in. Instead of passing in actor you may want to pass in user and switch the use of actor later on to user. I think it reads better as user
|
|
||
| let image = UIImage(named: "chevron-down").withRenderingMode(.alwaysTemplate) | ||
| let optionButtonWidth = (image.size.width ?? 0) + (2 * Styles.Sizes.gutter) | ||
| let optionButtonWidth = image.size.width + (2 * Styles.Sizes.gutter) |
There was a problem hiding this comment.
This isn't relevant to this PR
| event: event) | ||
| } | ||
|
|
||
| self.string = StyledTextRenderer( |
There was a problem hiding this comment.
nit: You don't need self. here right?
There was a problem hiding this comment.
Don't need, but I think is better for consistency since all other members being initialized require self. So doing all members even this with it :))
There was a problem hiding this comment.
They need self. because the parameter names match the variable names
There was a problem hiding this comment.
Yeah, but what I mean by consistency is
self.id = id
self.actor = actor
self.user = user
self.date = date
self.event = event
string = ... // Also a member
// Even it not needing, to maintain consistency in all memeber initialization
self.string = ... But can change if it is a problem :)
3 participants
Hey guys :))
This is a simple improvement on the
IssueRequestchanging the message when the users are the same. The same message that appears on the GitHub web interface.From:
To:
Also, some warnings removed :)