Fix for "Accessibility “bullets hollow” should be “more options” #2673 #2683
Conversation
Changed all occurrences of "bullets-hollow" to "chevron-down" to be consistent with the "More Options" button image used in MergeButton.swift
BasThomas
left a comment
BasThomas
left a comment
There was a problem hiding this comment.
Hm, this was actually not what I had in mind 😅
Not sure if this is better per se... thoughts?
If we do go ahead with this and are no longer using the bullets-hollow asset, we can remove it as well.
What this doesn't address is #2673; we should add an accessibilityLabel with "more options" (like here). It seems like it is missing for some of these. Can you address, that, @wayni208?
|
lol. Oh wow. Yes, I can do it correctly this time. Let me know if you guys want to keep that awesome chevron. :) |
|
I'm not opposed to it 😊 |
|
I personally feel it’s less standard. The bullets seem pretty standard across other apps. Sent with GitHawk |
|
Hm, I think I agree with @Huddie now. Mind changing it back to the |
|
Yes. I’ll get it now. |
Added accessibilityLabel and set to moreOptions.
|
Awesome! Sent with GitHawk |
3 participants
Changed all occurrences of "bullets-hollow" to "chevron-down" to be consistent with the "More Options" button image used in MergeButton.swift
Closes #2673