-
Notifications
You must be signed in to change notification settings - Fork 384
Update Setup.md #2684
Update Setup.md #2684
Conversation
|
I’m at work (on break) but would like to comment and offer some suggestions based on my observations installing and setting up the repo. I can do them later this afternoon. Would that be ok? |
|
@wayni208 Sure! sounds awesome! |
|
Here are some changes I would suggest. I would correct "navigation" to read "navigate" in 1. I would change 2 to say: In order to create "Copy of Freetime-AppCenter" the workspace must be open, allowing access to the schema. This is most of what I came here to say. I would change this section like this: Also, I am using Xcode 10 and when I duplicate the schema it immediately goes into edit mode. "Shared" is disabled by default. My issues were after I set up for Code Signing. Perhaps a note in this portion to let the contributor know that project, extension, and plist files will be out of sync and to avoid committing them would be appropriate? While it might be convenient to place these files in .gitignore I have noticed on a recent PR that the project file was updated/altered to account for a new class. |
|
I shall review and update! Thanks so much! Sent with GitHawk |
BasThomas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing, but love it! Thanks @Huddie :)
Added fork
Updated wording and added extra info step to added client id's
|
@wayni208 @BasThomas Review Request |
wayni208
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🖖
BasThomas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Huddie, looks good! 🤓
Slight confusion recently with entitlements, simulators vs physical devices etc.
This update of the setup guide will hopefully remedy this
Some minor wording updates as well