Skip to content
This repository was archived by the owner on Sep 20, 2023. It is now read-only.

Conversation

@Huddie
Copy link
Collaborator

@Huddie Huddie commented Mar 11, 2019

Slight confusion recently with entitlements, simulators vs physical devices etc.
This update of the setup guide will hopefully remedy this

Some minor wording updates as well

@Huddie Huddie requested a review from BasThomas March 11, 2019 14:52
@Huddie Huddie added 💤 awaiting review Pull Request is awaiting code reviews trivial labels Mar 11, 2019
@wayni208
Copy link
Contributor

I’m at work (on break) but would like to comment and offer some suggestions based on my observations installing and setting up the repo. I can do them later this afternoon. Would that be ok?

@Huddie
Copy link
Collaborator Author

Huddie commented Mar 11, 2019

@wayni208 Sure! sounds awesome!

@wayni208
Copy link
Contributor

Here are some changes I would suggest.

## 1. Cloning the repo
1. Create or navigation to a folder/directory where you’ll store the GitHawk project.

	Example: `mkdir ./desktop/GitHawkApp/`

2. In terminal clone the repo using: `git clone https://github.com/<YourGithubUsername>/GitHawk.git`

I would correct "navigation" to read "navigate" in 1. I would change 2 to say:

2. Open a terminal in the directory you just created or have selected to store the GitHawk project. In terminal, clone the repo using: `git clone https://github.com/<YourGithubUsername>/GitHawk.git`

In order to create "Copy of Freetime-AppCenter" the workspace must be open, allowing access to the schema. This is most of what I came here to say.

To add the Client ID and Client Secret to the App, follow these steps:

1. In Xcode, go to `Product` (in the Menu bar) > `Scheme` > `Manage Schemes...`
2. Select `Freetime-AppCenter` and click the cog.
3. Click on `Duplicate`.
4. Uncheck the `Shared` checkbox.
5. Select `Copy of Freetime-AppCenter` and click on `Edit...`
6. Go to `Run` > `Arguments`
7. Add your Client ID (`GITHUB_CLIENT_ID` as key) and Client Secret (`GITHUB_CLIENT_SECRET`) to the Environment Variables.

I would change this section like this:

To add the Client ID and Client Secret to the App, follow these steps:

1. In the directory you created, open the {YOUR_DIR}/GitHawk/Freetime.xcworkspace file.
2. In Xcode, go to `Product` (in the Menu bar) > `Scheme` > `Manage Schemes...`
3. Select `Freetime-AppCenter` and click the cog.
4. Click on `Duplicate`.
5. Select `Copy of Freetime-AppCenter` and uncheck "Shared" checkbox. 
6. With 'Copy of Freetime-Appcenter' selected, click on `Edit...`
6. Go to `Run` > `Arguments`
7. Add your Client ID (`GITHUB_CLIENT_ID` as key) and Client Secret (`GITHUB_CLIENT_SECRET`) to the Environment Variables.

Also, I am using Xcode 10 and when I duplicate the schema it immediately goes into edit mode. "Shared" is disabled by default.

My issues were after I set up for Code Signing. Perhaps a note in this portion to let the contributor know that project, extension, and plist files will be out of sync and to avoid committing them would be appropriate? While it might be convenient to place these files in .gitignore I have noticed on a recent PR that the project file was updated/altered to account for a new class.

@Huddie
Copy link
Collaborator Author

Huddie commented Mar 11, 2019

I shall review and update! Thanks so much!

Sent with GitHawk

Copy link
Collaborator

@BasThomas BasThomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing, but love it! Thanks @Huddie :)

Huddie added 2 commits March 12, 2019 21:22
Added fork
Updated wording and added extra info step to added client id's
@Huddie
Copy link
Collaborator Author

Huddie commented Mar 13, 2019

@wayni208 @BasThomas Review Request

Copy link
Contributor

@wayni208 wayni208 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🖖

Copy link
Collaborator

@BasThomas BasThomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Huddie, looks good! 🤓

@BasThomas BasThomas merged commit f8efbc5 into master Mar 14, 2019
@BasThomas BasThomas deleted the setup-update branch March 14, 2019 18:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

💤 awaiting review Pull Request is awaiting code reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants