This repository was archived by the owner on Sep 20, 2023. It is now read-only.
Emojis! #2685
Merged
Emojis! #2685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Note: We already have a method that converts |
Member
|
Well that is simpler than I expected 😂 |
Collaborator
Author
BasThomas
approved these changes
Mar 12, 2019
|
|
||
| let color: String | ||
| let name: String | ||
| var name: String = "" |
Collaborator
There was a problem hiding this comment.
Any reason you changed this?
Collaborator
Author
There was a problem hiding this comment.
If let you can’t mutate. Meaning I can’t switch :bug: no?
Collaborator
There was a problem hiding this comment.
You're only setting it once in the initializer though, isn't it?
Collaborator
Author
There was a problem hiding this comment.
Oh yes! I originally had a separate fix (I created my
Own method that did the mapping. And I needed self but that doesn’t apply anymore. I’ll PR a quick fix to this soon. Thank you for pointing that out
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 😄
Yay! Closes #1616