Possible fix for #25 #26 #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Awesome! Lets give it a shot. Sent with GitHawk |
SD10
reviewed
Feb 16, 2018
| } | ||
|
|
||
| /// The NSAttributedStringKey.paragraphStyle value applied to attributed strings | ||
| private let paragraphStyle: NSMutableParagraphStyle = { |
Member
There was a problem hiding this comment.
Sorry to chime in after. Do we want to return it as a non-mutable NSParagraphyStyle?
Collaborator
There was a problem hiding this comment.
I guess that would make more sense, yeah
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't seem to recreate the bouncing in the MessageViewController example but in my other project I saw that this helped.
TL;DR
This just enforces a set paragraph style on all attributed strings