Skip to content

fix: Simplify Boolean.getBool() method logic #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2025
Merged

fix: Simplify Boolean.getBool() method logic #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c10469
fix: Simplify Boolean.getBool() method logic
GeekMasher Jun 16, 2025
1c851bb
fix: Remove duplicate expected output for AKS cluster API server and …
GeekMasher Jun 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ql/lib/codeql/bicep/ast/Literals.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,7 @@ class Array extends Literals instanceof ArrayImpl {
*/
class Boolean extends Literals instanceof BooleanImpl {
boolean getBool() {
exists(string bl |
bl = BooleanImpl.super.getValue().toLowerCase() and
exists(string bl | bl = BooleanImpl.super.getValue().toLowerCase() |
bl = "true" and
result = true
or
Expand Down
1 change: 0 additions & 1 deletion ql/test/queries-tests/security/AKS/AKSPublicApi.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
| aks-security-examples.bicep:2:1:30:1 | ManagedContainerResource | AKS cluster API server is publicly accessible (private cluster not enabled). |
| aks-security-examples.bicep:32:1:62:1 | ManagedContainerResource | AKS cluster API server is publicly accessible (private cluster not enabled). |
1 change: 0 additions & 1 deletion ql/test/queries-tests/security/CWE-327/TlsDisabled/TlsDisabled.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
| app.bicep:12:1:19:1 | RedisCacheResource | TLS is disabled for this resource |
| app.bicep:22:1:29:1 | RedisCacheResource | TLS is disabled for this resource |