-
Notifications
You must be signed in to change notification settings - Fork 6
Simplify docker setup #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify docker setup #68
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR simplifies the Docker release process by switching from copying files from a local checkout to installing the package directly from PyPI using pip install seclab-taskflow-agent. This change eliminates the need for the release.txt file and significantly reduces complexity in publish_docker.py.
- The Dockerfile is now a static file in the
docker/directory instead of being dynamically generated - The
publish_docker.pyscript no longer needs to copy files or generate Dockerfiles - The
release.txtfile containing the list of files to include has been removed
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| release_tools/release.sh | Updated command to remove obsolete release.txt and main.py arguments |
| release_tools/publish_docker.py | Removed file copying and Dockerfile generation logic; simplified to just build and push from the docker/ directory |
| release_tools/HOWTO.md | Updated documentation to reflect the simplified release command without release.txt |
| release.txt | Deleted file that was previously used to specify which files to include in the Docker image |
| docker/Dockerfile | New static Dockerfile that installs the package from PyPI and sets up dependencies |
| .github/workflows/release.yml | Updated workflow command to match the new simplified signature |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (2)
release_tools/publish_docker.py:5
- The imports
osandshutilare no longer used after removing the file copying functionality. These should be removed.
import os
import shutil
release_tools/HOWTO.md:24
- The documentation references the outdated entrypoint
/app/main.py, but the new Dockerfile usespython -m seclab_taskflow_agent. This should be updated to reflect the new entrypoint or clarify that it's conceptual.
The default entry point for our Agent Docker image is `/app/main.py`. If you'd like to deploy one of our MCP servers as a standalone server via the Docker image, use `--entrypoint` to set the appropriate entry point.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
97bb216 to
003522b
Compare
This changes the docker setup to use
pip install seclab-taskflow-agent, rather than copying the files from a local checkout. It means thatrelease.txtis no longer needed, and a lot of the code inpublish_docker.pycan be deleted. Also, theDockerfileis now a static file, rather than generated by the script.There isn't much code left in the
release_toolsdirectory. As a follow-up, we could probably delete the directory and move the remaining logic into therelease.ymlworkflow file.