Publish to central #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbransby
requested changes
Mar 25, 2020
Member
nbransby
left a comment
nbransby
left a comment
There was a problem hiding this comment.
are you going to delete the pom?
.gitignore
Outdated
| .gradle/ | ||
|
|
||
| /node_modules | ||
| /src/commonMain/kotlin/.DS_Store |
build.gradle.kts
Outdated
| } | ||
| dependsOn(copyPackageJson, copyJS, copySourceMap) | ||
| workingDir("$buildDir/node_module") | ||
| if(Os.isFamily(Os.FAMILY_WINDOWS)) { |
Author
There was a problem hiding this comment.
Do you mean just Os.isFamily?
Member
There was a problem hiding this comment.
yeah the only reason to make it OS specific was to run 2 command in one line which youi have removed now
nbransby
approved these changes
Mar 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has package renaming, replacement of TeamHubApp with GitLiveApp. NPM publishing to main registry