Feature/bookmarks #558
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| const express = require('express'); | ||
| const router = express.Router(); | ||
| const User = require('../models/User'); | ||
|
|
||
| // Simple auth check middleware (session-based via passport) | ||
| function ensureAuth(req, res, next) { | ||
| if (req.isAuthenticated && req.isAuthenticated()) return next(); | ||
| return res.status(401).json({ message: 'Authentication required' }); | ||
| } | ||
|
|
||
| // GET /api/bookmarks - returns current user's bookmarks | ||
| router.get('/', ensureAuth, async (req, res) => { | ||
| try { | ||
| console.log('GET /api/bookmarks req.isAuthenticated=', req.isAuthenticated && req.isAuthenticated(), 'user=', req.user && req.user.id); | ||
| const user = await User.findById(req.user._id).select('bookmarks'); | ||
| return res.json({ bookmarks: user?.bookmarks || [] }); | ||
| } catch (err) { | ||
| console.error('Error fetching bookmarks', err); | ||
| return res.status(500).json({ message: 'Failed to fetch bookmarks', error: err.message }); | ||
| } | ||
| }); | ||
|
|
||
| // POST /api/bookmarks - add a bookmark | ||
| router.post('/', ensureAuth, async (req, res) => { | ||
| try { | ||
| console.log('POST /api/bookmarks req.isAuthenticated=', req.isAuthenticated && req.isAuthenticated(), 'user=', req.user && req.user.id, 'body=', req.body); | ||
| const { githubUsername, avatarUrl } = req.body; | ||
| if (!githubUsername || !githubUsername.trim()) { | ||
| return res.status(400).json({ message: 'githubUsername is required' }); | ||
| } | ||
|
|
||
| const user = await User.findById(req.user._id); | ||
| if (!user) return res.status(404).json({ message: 'User not found' }); | ||
|
|
||
| const exists = user.bookmarks?.some( | ||
| (b) => b.githubUsername.toLowerCase() === githubUsername.toLowerCase() | ||
| ); | ||
| if (exists) return res.status(409).json({ message: 'Bookmark already exists' }); | ||
|
|
||
| user.bookmarks = user.bookmarks || []; | ||
| user.bookmarks.unshift({ githubUsername, avatarUrl }); | ||
| await user.save(); | ||
|
|
||
| return res.status(201).json({ message: 'Bookmark saved', bookmark: user.bookmarks[0] }); | ||
| } catch (err) { | ||
| console.error('Error saving bookmark', err); | ||
| return res.status(500).json({ message: 'Failed to save bookmark', error: err.message }); | ||
| } | ||
| }); | ||
|
|
||
| // DELETE /api/bookmarks/:username - remove bookmark | ||
| router.delete('/:username', ensureAuth, async (req, res) => { | ||
| try { | ||
| console.log('DELETE /api/bookmarks/:username req.isAuthenticated=', req.isAuthenticated && req.isAuthenticated(), 'user=', req.user && req.user.id, 'params=', req.params); | ||
| const username = req.params.username; | ||
| const user = await User.findById(req.user._id); | ||
| if (!user) return res.status(404).json({ message: 'User not found' }); | ||
|
|
||
| const before = (user.bookmarks || []).length; | ||
| user.bookmarks = (user.bookmarks || []).filter( | ||
| (b) => b.githubUsername.toLowerCase() !== username.toLowerCase() | ||
| ); | ||
|
|
||
| if (user.bookmarks.length === before) { | ||
| return res.status(404).json({ message: 'Bookmark not found' }); | ||
| } | ||
|
|
||
| await user.save(); | ||
| return res.json({ message: 'Bookmark removed' }); | ||
| } catch (err) { | ||
| return res.status(500).json({ message: 'Failed to remove bookmark', error: err.message }); | ||
| } | ||
| }); | ||
|
|
||
| module.exports = router; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prevent hardcoded session secret in production.
The fallback
'dev-secret'is a security risk if theSESSION_SECRETenvironment variable is not set in production. A weak or known secret enables session forgery and hijacking attacks.🔒 Enforce SESSION_SECRET in production
Option 1 (recommended): Fail fast in production if secret is missing:
app.use(session({ - secret: process.env.SESSION_SECRET || 'dev-secret', + secret: process.env.SESSION_SECRET || (() => { + if (process.env.NODE_ENV === 'production') { + throw new Error('SESSION_SECRET must be set in production'); + } + logger.warn('Using dev-secret for session - DO NOT use in production'); + return 'dev-secret'; + })(), resave: false, saveUninitialized: false,Option 2 (simpler): Require SESSION_SECRET always:
And document in README/env.example that developers must set
SESSION_SECRET=dev-secretlocally.📝 Committable suggestion
🤖 Prompt for AI Agents