Skip to content

Ensure pending or in-review sites still get placeholder ads even without preview query param #2535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 18, 2024
Merged

Ensure pending or in-review sites still get placeholder ads even without preview query param #2535

merged 2 commits into from
Oct 18, 2024

Conversation

@spastorelli
Copy link
Contributor

@spastorelli spastorelli commented Oct 18, 2024

This PR aims to fix an issue where sites in pending or in-review statuses were not getting the placeholder ads unless explicitly providing ads_preview=placeholder to the URL.

@changeset-bot
Copy link

changeset-bot bot commented Oct 18, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 1d5b8d2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot temporarily deployed to gitbook-open (Preview) October 18, 2024 13:41 Inactive
@spastorelli spastorelli changed the title Ensure pending or in-review sites still get placeholder ads without preview query param Ensure pending or in-review sites still get placeholder ads even without preview query param Oct 18, 2024
@argos-ci
Copy link

argos-ci bot commented Oct 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 26 changed Oct 18, 2024, 3:07 PM

@github-actions github-actions bot temporarily deployed to gitbook-open (Preview) October 18, 2024 15:01 Inactive
@spastorelli spastorelli merged commit 63bacaa into main Oct 18, 2024
8 checks passed
@spastorelli spastorelli deleted the steeve/fix-issue-placeholder-ads-not-rendered-without-ads-preview branch October 18, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SamyPesse SamyPesse SamyPesse approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@spastorelli @SamyPesse