Improving the new tabs #2537
Merged
Improving the new tabs #2537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7c72fdb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
requested a deployment
to
gitbook-open (Preview)
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
BrettJephson
force-pushed
the
brett/better-tabs
branch
from
a7ef15b to
ea48998
Compare
BrettJephson
commented
Oct 21, 2024
Contributor
Author
BrettJephson
left a comment
BrettJephson
left a comment
There was a problem hiding this comment.
Self-review:
BrettJephson
force-pushed
the
brett/better-tabs
branch
from
e3e29f8 to
d27fb90
Compare
taranvohra
reviewed
Oct 21, 2024
taranvohra
approved these changes
Oct 21, 2024
packages/gitbook/src/app/(site)/(content)/[[...pathname]]/page.tsx
Outdated
Show resolved
Hide resolved
packages/gitbook/src/components/TableOfContents/TableOfContents.tsx
Outdated
Show resolved
Hide resolved
packages/gitbook/src/components/TableOfContents/TableOfContents.tsx
Outdated
Show resolved
Hide resolved
BrettJephson
force-pushed
the
brett/better-tabs
branch
from
89d9bb4 to
7c72fdb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to tab design. Better hit area and only change active tab when page loads.
Note to reviewer - I had to do some work to get the Page outline to work as sticky with the section tabs. That includes reluctant use of
float-right. I've tested it with various customizations (no header, no sections) but more testing would be welcome!Preview:
