Adds missing css variables #2558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c425658 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
antlio
force-pushed
the
anthony/style-api-doc-scalar-variables
branch
from
ff7dae6 to
a411ae8
Compare
amritk
force-pushed
the
anthony/style-api-doc-scalar-variables
branch
from
d18f410 to
a3c6033
Compare
jmanomoon
approved these changes
Nov 5, 2024
Contributor
|
@SamyPesse any idea why this is failing? |
hwkr
approved these changes
Nov 9, 2024
|
Oh oops I thought this was Scalar 😂 @antlio you're doing great 🫡 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds missing css variables in the scalar.css stylesheet in order to fix the missing selection style as seen below. The chosen color background respect the default one as close as possible, as seen below:
before / after:
