Skip to content

Conversation

@viktorrenkema
Copy link
Contributor

  • Adds back the vertical lines for tables, got feedback from Snyk that they preferred without. We'll reintroduce the ability to hide these lines as a config on table level instead
  • Add hover state over hovered table rows to also improve readability of large tables

Checked with @zenoachtig

After

CleanShot.2024-12-19.at.09.54.29.mp4

@changeset-bot
Copy link

changeset-bot bot commented Dec 20, 2024

🦋 Changeset detected

Latest commit: 06076e5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
gitbook Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Dec 20, 2024

GitBook Preview
Latest commit: https://c8794d69.gitbook-open.pages.dev
PR: https://pr2653.gitbook-open.pages.dev

@argos-ci
Copy link

argos-ci bot commented Dec 20, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ⚠️ Changes detected (Review) 214 changed Dec 31, 2024, 11:11 PM


.row {
@apply flex border-tint-700/2;
@apply flex border-tint-700/2 hover:bg-tint-700/2 transition-colors;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally I'd apply hover:bg-tint-700/1 dark:hover:bg-tint-700/2 so the dark mode hover color is different than the light-mode, but tailwind doesn't agree. Open to suggestions, otherwise ill look into it later and fix after.

Copy link
Contributor

@emmerich emmerich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget a changeset!

@viktorrenkema viktorrenkema force-pushed the viktor/restore-table-lines branch 3 times, most recently from 21265c1 to 18e79f5 Compare December 24, 2024 13:02
@viktorrenkema viktorrenkema force-pushed the viktor/restore-table-lines branch from 18e79f5 to 482a0a9 Compare December 24, 2024 13:27
@viktorrenkema viktorrenkema merged commit 8126a83 into main Dec 25, 2024
9 checks passed
@viktorrenkema viktorrenkema deleted the viktor/restore-table-lines branch December 25, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants