Skip to content

Conversation

@viktorrenkema
Copy link
Contributor

We added support for setting objectFit on card covers. But if those were never defined yet, the current logic fell short in that we wouldnt handle a default value. This PR ensures that if no object-fit was set, we default to 'cover' which we always had before.

Before:
CleanShot 2025-09-05 at 10 22 06@2x

After:
CleanShot 2025-09-05 at 10 22 48@2x

~closes https://linear.app/gitbook-x/issue/RND-8043/inconsistent-card-image-rendering-on-published-site

@linear
Copy link

linear bot commented Sep 5, 2025

@changeset-bot
Copy link

changeset-bot bot commented Sep 5, 2025

⚠️ No Changeset found

Latest commit: ae25751

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@argos-ci
Copy link

argos-ci bot commented Sep 5, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
customers-v2 (Inspect) 👍 Changes approved 17 changed Sep 5, 2025, 8:30 AM
v2-cloudflare (Inspect) 👍 Changes approved 15 changed Sep 5, 2025, 8:34 AM
v2-vercel (Inspect) 👍 Changes approved 20 changed Sep 5, 2025, 8:42 AM

@viktorrenkema viktorrenkema merged commit 177afa5 into main Sep 5, 2025
24 checks passed
@viktorrenkema viktorrenkema deleted the viktor/cards/fix-default-object-fit branch September 5, 2025 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants