Skip to content

Fix cross-space content reference resolution and enhance anchor text rendering #3754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 24, 2025
Merged

Fix cross-space content reference resolution and enhance anchor text rendering #3754

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aeabef4
Fix: forward resolve options for cross-space content refs and improve…
conico974 Oct 24, 2025
00a7d04
linting
conico974 Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions packages/gitbook/src/lib/references.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ export async function resolveContentRef(
case 'anchor':
case 'page': {
if (contentRef.space && contentRef.space !== space.id) {
return resolveContentRefInSpace(contentRef.space, context, contentRef);
return resolveContentRefInSpace(contentRef.space, context, contentRef, options);
}

const resolvePageResult =
Expand Down Expand Up @@ -165,7 +165,13 @@ export async function resolveContentRef(
if (document) {
const block = getBlockById(document, anchor);
if (block) {
text = getBlockTitle(block);
// If the anchor points to the current page, we just resolve the text from the block.
// This avoids showing the page title twice.
if (isCurrentPage) {
text = `#${getBlockTitle(block)}`;
} else {
text = `${page.title} #${getBlockTitle(block)}`;
}
}
}
}
Expand Down Expand Up @@ -345,15 +351,16 @@ async function getBestTargetSpace(
async function resolveContentRefInSpace(
spaceId: string,
context: GitBookAnyContext,
contentRef: ContentRef
contentRef: ContentRef,
options: ResolveContentRefOptions = {}
) {
const ctx = await createContextForSpace(spaceId, context);

if (!ctx) {
return null;
}

const resolved = await resolveContentRef(contentRef, ctx.spaceContext);
const resolved = await resolveContentRef(contentRef, ctx.spaceContext, options);

if (!resolved) {
return null;
Expand Down