Skip to content

Conversation

@nolannbiron
Copy link
Member

No description provided.

@linear
Copy link

linear bot commented Dec 13, 2025

@changeset-bot
Copy link

changeset-bot bot commented Dec 13, 2025

🦋 Changeset detected

Latest commit: 3321428

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@gitbook/react-openapi Patch
gitbook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@argos-ci
Copy link

argos-ci bot commented Dec 13, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
customers-v2 (Inspect) 👍 Changes approved 1 changed Dec 13, 2025, 9:52 AM
v2-cloudflare (Inspect) 👍 Changes approved 39 changed Dec 13, 2025, 10:12 AM
v2-vercel (Inspect) 👍 Changes approved 16 changed Dec 13, 2025, 9:56 AM

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the property handling logic in OpenAPI schema processing to properly collect and merge properties from schemas using allOf. The implementation extracts common property processing logic into reusable helper functions and adds special handling for allOf schemas to collect properties from all sub-schemas and merge them correctly, including proper handling of required field annotations.

Key Changes

  • Extracted property processing logic into processSchemaProperties helper function
  • Added mergeProperties helper to merge properties with later definitions overriding earlier ones
  • Implemented allOf handling that recursively collects and merges properties from all schemas in the allOf array

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
packages/react-openapi/src/OpenAPISchema.tsx Refactored getSchemaProperties to add allOf support by extracting reusable helpers and implementing recursive property collection and merging logic
.changeset/chatty-glasses-move.md Added changeset documenting the fix for missing properties in allOf/oneOf schemas

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@nolannbiron nolannbiron merged commit 4766092 into main Dec 13, 2025
29 of 30 checks passed
@nolannbiron nolannbiron deleted the nolann/rnd-9094-openapi-inheritance-allof-referenced-schemas-no-longer branch December 13, 2025 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants