Skip to content

add isComposing to search#4244

Merged
addisonschultz merged 2 commits into
mainfrom
addison/rnd-10848-search-bar-in-gitbook-sites-doesnt-respect-iscomposing-for
May 8, 2026
Merged

add isComposing to search#4244
addisonschultz merged 2 commits into
mainfrom
addison/rnd-10848-search-bar-in-gitbook-sites-doesnt-respect-iscomposing-for

Conversation

@addisonschultz
Copy link
Copy Markdown
Contributor

@addisonschultz addisonschultz commented May 8, 2026

Before (pressing enter submits the form, without accepting the composition):

CleanShot.2026-05-08.at.14.55.48.mp4

After (pressing enter accepts the composition) [expected]:

CleanShot.2026-05-08.at.14.57.30.mp4

@linear-code
Copy link
Copy Markdown

linear-code Bot commented May 8, 2026

RND-10848

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 8, 2026

🦋 Changeset detected

Latest commit: eae364d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
gitbook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@argos-ci
Copy link
Copy Markdown

argos-ci Bot commented May 8, 2026

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
customers-v2-cloudflare (Inspect) ✅ No changes detected - May 8, 2026, 5:54 AM
customers-v2-vercel (Inspect) ✅ No changes detected - May 8, 2026, 5:54 AM
v2-cloudflare (Inspect) 👍 Changes approved 24 changed May 8, 2026, 9:39 AM
v2-vercel (Inspect) 👍 Changes approved 17 changed May 8, 2026, 8:19 AM

@addisonschultz addisonschultz requested a review from zenoachtig May 8, 2026 05:58
@addisonschultz
Copy link
Copy Markdown
Contributor Author

@zenoachtig do you know why the test is failing? 😢

@addisonschultz addisonschultz merged commit 6ba5e54 into main May 8, 2026
31 of 35 checks passed
@addisonschultz addisonschultz deleted the addison/rnd-10848-search-bar-in-gitbook-sites-doesnt-respect-iscomposing-for branch May 8, 2026 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants