CLI: Add string validation for integration names#763
Merged
Conversation
|
commit: |
SamyPesse
reviewed
Mar 19, 2025
…b.com:GitbookIO/integrations into update/cli/string_validation_integration_name
…b.com:GitbookIO/integrations into update/cli/string_validation_integration_name
SamyPesse
approved these changes
Apr 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, it is possible to specify an integration name in the CLI package initialization flow that will show up as invalid when you try and publish the package. This PR adds a string validation step that uses the same criteria as the API to make sure the string is valid.
I copied the validation functions directly since this repo is public, while the gitbook-x repo is private. I'm happy to update this if there's a better way to import that validation function directly here.