Skip to content

CLI: Add string validation for integration names#763

Merged
talagluck merged 14 commits intomainfrom
update/cli/string_validation_integration_name
Apr 2, 2025
Merged

CLI: Add string validation for integration names#763
talagluck merged 14 commits intomainfrom
update/cli/string_validation_integration_name

Conversation

@talagluck
Copy link
Contributor

Currently, it is possible to specify an integration name in the CLI package initialization flow that will show up as invalid when you try and publish the package. This PR adds a string validation step that uses the same criteria as the API to make sure the string is valid.

I copied the validation functions directly since this repo is public, while the gitbook-x repo is private. I'm happy to update this if there's a better way to import that validation function directly here.

@changeset-bot
Copy link

changeset-bot bot commented Mar 18, 2025

⚠️ No Changeset found

Latest commit: d714d44

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 18, 2025

Open in StackBlitz

bun add https://pkg.pr.new/GitbookIO/integrations/@gitbook/api@763

commit: d714d44

@talagluck talagluck requested a review from SamyPesse March 20, 2025 10:52
@talagluck talagluck merged commit 3fb9973 into main Apr 2, 2025
7 checks passed
@talagluck talagluck deleted the update/cli/string_validation_integration_name branch April 2, 2025 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants