Don't filter out old versions or -delta from the RELEASES file. Closes #22 #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
(Also, sorry if my initial comments sounded harsh/entitled, that wasn't my intention at all! 🌰 is a great piece of software and I'm really happy you made it ^_^) |
Member
|
Thanks, I'll run some tests with our application in the coming days then merge the PR 🚀 |
Contributor
Author
There was a problem hiding this comment.
Ha, I didn't expect the PR to be based on master. Will fix later today, ignore for now
Contributor
Author
|
By the way there is an issue with this PR that is fixed by itchio@650d399 The other commit is unrelated to the PR, sorry about the noise! |
Contributor
Author
|
Closed in favor of #24 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes typo :)
Can confirm that this does wonder for our desktop app
Squirrel.Windows checks the RELEASES file and happily picks the delta update that is much, much smaller than the full one.
(It still downloads it twice for some reason (presumably to get changelogs?), though, but that's okay — two times 60kb is still pretty small
)