Skip to content

Don't filter out old versions or -delta from the RELEASES file. Closes #22 #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fasterthanlime wants to merge 3 commits into from
Closed

Don't filter out old versions or -delta from the RELEASES file. Closes #22 #23

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
45946cc
Don't filter out old versions or -delta from the RELEASES file. Close…
fasterthanlime Dec 15, 2015
abe3e98
Better error message
fasterthanlime Dec 17, 2015
650d399
Proxy via the right URLs
fasterthanlime Dec 17, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ module.exports = function nuts(opts) {
if (req.useragent.isLinux64) platform = platforms.LINUX_64;
}

if (!platform) return next(new Error('No platform specified and impossible to detect one'));
if (!platform) return next(new Error('We could not detect your platform.\n\nPlease pick a download directly from: https://github.com/itchio/itch/releases\n\nThanks!'));
Copy link
Member

@SamyPesse SamyPesse Dec 17, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hum?

Copy link
Contributor Author

@fasterthanlime fasterthanlime Dec 17, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha, I didn't expect the PR to be based on master. Will fix later today, ignore for now

} else {
platform = null;
}
Expand Down Expand Up @@ -224,14 +224,9 @@ module.exports = function nuts(opts) {

releases = _.chain(releases)

// Exclude deltas and other versions
.filter(function(entry) {
return (!entry.isDelta && entry.version == winReleases.normVersion(latest.tag));
})

// Change filename to use downlaodp roxy
// Change filename to use download proxy
.map(function(entry) {
entry.filename = url.resolve(fullUrl, '/download/'+latest.tag+'/'+entry.filename);
entry.filename = url.resolve(fullUrl, '/download/'+entry.version+'/'+entry.filename);

return entry;
})
Expand Down