Add errors for removeBackportLabelsFromPrs
#129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For debugging purposes Signed-off-by: Yarden Shoham <git@yardenshoham.com>
silverwind
reviewed
May 17, 2024
| export const removeBackportLabelsFromPrs = (prs) => { | ||
| if (prs === undefined) { | ||
| throw new Error("removeBackportLabelsFromPrs called with undefined"); | ||
| } |
Collaborator
There was a problem hiding this comment.
If you add a type to prs, typescript could statically determine whether this function could ever be called with undefined.
But fine with me regardless if you just want to debug.
silverwind
approved these changes
May 17, 2024
Collaborator
|
Would prefer if you would not immediately enable auto merge in the future. Often I like to approve with remarks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For debugging purposes