Fix: MediaList overflow & animation #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on gitkubikon's Media card implementation: - Tab-based interface with screenshot/recording mode switching - Compact header design without verbose descriptions - Contextual SplitButton that adapts to active tab - Unified MediaList component for both screenshots and recordings - Space-efficient design with better information density
- Fix placeholder overflow by using viewport.animatedHeight instead of pseudoContainer.height - Reduce Y animation duration for big variant to 60% for smoother tracking - Remove Y animation for small variant to eliminate stagger during collapse
Gitkubikon
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You mentioned the issues with the placeholder text clipping outside of the container, this should do the trick and avoids a bit of "staggering" when collapsing it again.