Skip to content

Fix: MediaList overflow & animation #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 29, 2025
Merged

Fix: MediaList overflow & animation #1

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2df8716
feat: unified media capture
Gitkubikon Sep 28, 2025
3f5d8ec
fix: placeholder overflow and animation stagger in MediaList
PixelKhaos Sep 28, 2025
eaf31d2
Merge branch 'screenshot-card' into feat/unified-capture
PixelKhaos Sep 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions modules/utilities/cards/MediaList.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,13 +221,15 @@ ColumnLayout {
width: bigCol.implicitWidth
height: bigCol.implicitHeight
x: Math.max(0, (phWrap.width - width) / 2)
// Desired center based on TARGET height; then clamped by CURRENT viewport height
property real desiredCenter: Math.max(0, (pseudoContainer.height - height) / 2)

// Desired center based on CURRENT animated height to prevent overflow during animation
property real desiredCenter: Math.max(0, (viewport.animatedHeight - height) / 2)

y: phWrap.clampedYFor(big, viewport.expandedTarget ? big.desiredCenter : 0)

Behavior on opacity { Anim { duration: heightAnim.duration } }
Behavior on scale { Anim { duration: heightAnim.duration } }
Behavior on y { Anim { duration: heightAnim.duration; easing: heightAnim.easing } }
Behavior on y { Anim { duration: heightAnim.duration * 0.6; easing: heightAnim.easing } }

Column {
id: bigCol
Expand Down Expand Up @@ -258,12 +260,15 @@ ColumnLayout {
width: smallRow.implicitWidth
height: smallRow.implicitHeight
x: Math.max(0, (phWrap.width - width) / 2)
property real desiredCenter: Math.max(0, (pseudoContainer.height - height) / 2)
y: phWrap.clampedYFor(small, viewport.expandedTarget ? 0 : small.desiredCenter)

property real desiredCenter: Math.max(0, (viewport.animatedHeight - height) / 2)
y: phWrap.clampedYFor(small, viewport.expandedTarget ? small.desiredCenter : small.desiredCenter)

Behavior on opacity { Anim { duration: heightAnim.duration } }
Behavior on scale { Anim { duration: heightAnim.duration } }
Behavior on y { Anim { duration: heightAnim.duration; easing: heightAnim.easing } }
// Remove Y animation for small variant to eliminate stagger during collapse
// Behavior on y { Anim { duration: heightAnim.duration * 0.6; easing: heightAnim.easing } }


Row {
id: smallRow
Expand Down