fix(release): use simple release-type + generic Cargo.toml updaters#130
Conversation
release-type: rust at path . is incompatible with this virtual workspace root. release-please's Rust strategy unconditionally appends a CargoToml update for the root Cargo.toml, and that updater throws "is not a package manifest (might be a cargo workspace)" whenever the manifest has no [package] section — so every run died on the final step. Switch to release-type: simple (touches only a version file + CHANGELOG, never a manifest) and bump each crate version through the generic updater via extra-files plus an inline x-release-please-version annotation. Preserves the single vX.Y.Z tag, all action outputs, and the entire downstream release.yml unchanged.
|
Thanks for the contribution. A couple of things will help us review this faster:
See CONTRIBUTING.md. Update the PR and these notes will clear automatically. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (7)
📝 WalkthroughWalkthroughSwitches the release-please configuration from the ChangesRelease-please simple strategy migration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Summary
Fix the failing
release-pleasejob: switch the workspace fromrelease-type: rusttosimpleand bump per-crate versions via the generic updater, so releases can actually be cut.Motivation & context
release-type: rustat path.is incompatible with our virtual workspace root. release-please's Rust strategy unconditionally appends aCargoTomlupdate for the rootCargo.toml, and that updater throwsis not a package manifest (might be a cargo workspace)whenever the manifest has no[package]section — so every Release run died on the final step.Kind of change
What changed
release-please-config.json:release-typerust→simple; addedextra-fileslisting all 5 crateCargo.tomls with the generic updater.# x-release-please-versionannotation to theversionline of each crate (gitlawb-core / gitlawb-node / gl / git-remote-gitlawb / gitlawb-attest).Cargo.toml.vX.Y.Ztag, all action outputs (release_created/tag_name/version), and the entire downstreamrelease.ymlunchanged.Cargo.lockis intentionally unmanaged (CI doesn't build--locked; cargo regenerates it).How a reviewer can verify