Is kstring still the best approact?

[Ed Page (epage)]

I don't remember why you adopted kstring but the state of the art with other crates has likely passed it and I've not felt the need to competed

For other options, see https://github.com/rosetta-rs/string-rosetta-rs/

[Sebastian Thiel (Byron)]

Thanks for sharing!

I assume this is about verifying that this optimization is necessary, and to find out if kstring can be removed entirely or replaced based on actual benchmarks. Those are in the making know and I'd hope we will know more then.

Generally, kstring was supposed to be a binary-string compatible container for strings that avoids allocations. All this though was done without profiling or benchmarks, so it's wise to question it.

[Ed Page (epage)]

I looked through the list at the above link and the following have some kind of byte string

• https://docs.rs/ecow/0.3.0/ecow/
• https://docs.rs/flexstr/0.11.7/flexstr/
• https://docs.rs/hipstr/0.8.0/hipstr/

[Jiahao XU (NobodyXu)]

Would highly recommend compact-string, used it in cargo-binstall and I've contributed to it on the static string support
ParkMyCar/compact_str#273

[Ed Page (epage)]

compact_str only supports UTF 8 strings and not Byte strings.

[Sebastian Thiel (Byron)]

I added a benchmark, and with kstring replaced with Rc/Arc<str> it's 5% to 2% faster than kstring. Good call!