Move worktree_branches call out of loop in ref update #2249
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
worktree_branchesopens every worktree as aRepositoryto resolve itsHEAD. This is currently getting called in the loop over ref mappings, but I do not see why it needs to be. Moving it outside the loop results in a pretty significant performance increase (~10x in my case) for fetch when worktree(s) are present, dependent on how many refs exist in the repository and the value configured forobject_store_slots. In my case,object_store_slotswas set relatively high, resulting in slow drop forgix_odb::Storeand hencegix::Repository.