feat: add Prefix::from_hex_nonempty() to allow creating short prefixes.
#2297
+88
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds a new method Prefix::from_hex_nonempty() that allows creating prefix instances from shorter hexadecimal strings (as short as 1 character), which can be useful when working with small sets of candidate object IDs. The existing from_hex() method has been refactored to delegate to the new method after checking the minimum length constraint.
Key Changes:
- Refactored
Prefix::from_hex()to enforce the 4-character minimum and delegate to the new method - Added
Prefix::from_hex_nonempty()that accepts any non-empty hex string (1+ characters) - Added comprehensive test suite for the new functionality
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| gix-hash/src/prefix.rs | Implements the new from_hex_nonempty() method and refactors from_hex() to use it |
| gix-hash/tests/hash/prefix.rs | Adds test module covering various input lengths for the new method, including edge cases |
| Cargo.lock | Dependency version updates (unrelated to the feature) |
…xes. This can be useful in certain situations where the set of candidate object ids is very small.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be useful in certain situations where the set of candidate object ids is very small.