Reject whitespace in URL hostnames per RFC 3986 #2356
Merged
+34
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gix_url::parse()incorrectly accepted URLs with whitespace in hostnames (e.g.,"http://has a space"), diverging from RFC 3986 and the standardurlcrate behavior.Changes:
simple_url::normalize_hostname()to reject any whitespace characters (space, tab, newline, etc.) in hostnamesExample:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.