Validate URL components per RFC 3986: reject unencoded whitespace #2357
+57
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
simple_urlparser was accepting unencoded whitespace in URL components, violating RFC 3986 which requires whitespace to be percent-encoded.Changes
char::is_whitespaceInvalidDomainCharacterfor consistency with existing host validationExample
The validation is applied during URL parsing in
ParsedUrl::parse(), catching invalid characters before the URL components are stored.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.