index::State::to_tree()#2560
Draft
Sebastian Thiel (Byron) wants to merge 3 commits intomainfrom
Draft
Conversation
Sebastian Thiel (Byron)
force-pushed
the
write-tree
branch
2 times, most recently
from
179a475 to
08a7604
Compare
The PR CI lint job failed with clippy::semicolon-if-nothing-returned in gix-status/tests/status/index_as_worktree.rs after the keep-tree-cache call was expanded into a block closure. Add the requested semicolon so the closure has an explicit unit statement. The fast-test matrix also failed after tests regenerated gix-index/tests/fixtures/generated-archives/v2_deeper_tree.tar and git diff reported the archive had changed. The archive still carried an older fixture identity, so regenerate it from the current v2_deeper_tree fixture script identity to prevent CI from rewriting it.
Sebastian Thiel (Byron)
force-pushed
the
write-tree
branch
from
08a7604 to
d0a7ea3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow writing back a tree in the hopes that it will be faster than what
git2offers.The reason that's slow is also that we don't currently maintain the tree-cache when editing the index,
but instead remove it.
However, this is also something that could be added.
Related to gitbutlerapp/gitbutler#13566 .
Tasks