feat!: add object_hash to gix::create::Options#2578
Draft
Christoph Rüßler (cruessler) wants to merge 2 commits intoGitoxideLabs:mainfrom
Draft
feat!: add object_hash to gix::create::Options#2578Christoph Rüßler (cruessler) wants to merge 2 commits intoGitoxideLabs:mainfrom
object_hash to gix::create::Options#2578Christoph Rüßler (cruessler) wants to merge 2 commits intoGitoxideLabs:mainfrom
Conversation
Use `GIX_TEST_FIXTURE_HASH` for `gix` tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
object_hashtogix::create::Options. This addition was initially triggered by me wanting to run the first batch ofgixtests withGIX_TEST_FIXTURE_HASH=sha256.This is still a draft as I want to double-check the changes to make sure I didn’t miss feature flags anywhere. I’m pretty sure
Sha256intry_into_object_formatneeds to be feature-gated, but since tests have been passing locally, this was not a top priority so far.This is part of #281.