add methods to create fourwings AIS and SAR presence reports#29
Merged
add methods to create fourwings AIS and SAR presence reports#29
Conversation
This: - adds `create_fishing_effort_report`, `create_ais_presence_report`, and `create_sar_presence_report` methods to `FourWingsResource` - enhances `FourWingsReportEndPoint` to better validate and safely transform nested response entries - updates unit tests to cover new report creation methods and edge cases in response data validation and transformation. - updates and rename integration tests to clarify report grouping (e.g. yearly grouped by flag, monthly by gear type) - adds new integrations tests for SAR vessel detection matched reports and AIS vessel presence with various filters - improves docstrings and comments for clarity in report endpoints and resources
giselamo
reviewed
Aug 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This:
fishing effort,AIS presence, andSAR presencereports inFourWingsResourceFourWingsReportEndPoint