Skip to content

add methods to create fourwings AIS and SAR presence reports#29

Merged
lykmapipo merged 3 commits intodevelopfrom
feature/fourwings-shortcuts
Aug 18, 2025
Merged

add methods to create fourwings AIS and SAR presence reports#29
lykmapipo merged 3 commits intodevelopfrom
feature/fourwings-shortcuts

Conversation

@lykmapipo
Copy link
Copy Markdown
Collaborator

This:

  • Adds methods to create fishing effort, AIS presence, and SAR presence reports in FourWingsResource
  • Improves validation and safe transformation of nested responses in FourWingsReportEndPoint
  • Updates unit tests to cover new report methods and edge cases
  • Adds integration tests for SAR vessel detection and AIS vessel presence reports

This:
- adds `create_fishing_effort_report`, `create_ais_presence_report`, and `create_sar_presence_report` methods to `FourWingsResource`
- enhances `FourWingsReportEndPoint` to better validate and safely transform nested response entries
- updates unit tests to cover new report creation methods and edge cases in response data validation and transformation.
- updates and rename integration tests to clarify report grouping (e.g. yearly grouped by flag, monthly by gear type)
- adds new integrations tests for SAR vessel detection matched reports and AIS vessel presence with various filters
- improves docstrings and comments for clarity in report endpoints and resources
@lykmapipo lykmapipo self-assigned this Aug 11, 2025
@lykmapipo lykmapipo added documentation Improvements or additions to documentation enhancement New feature or request labels Aug 11, 2025
Comment thread src/gfwapiclient/resources/fourwings/resources.py
Comment thread src/gfwapiclient/resources/fourwings/resources.py
Comment thread src/gfwapiclient/resources/fourwings/resources.py
@lykmapipo lykmapipo merged commit 2bc5944 into develop Aug 18, 2025
4 checks passed
@lykmapipo lykmapipo deleted the feature/fourwings-shortcuts branch August 18, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants