Merged
Conversation
…the file reached the end. The issue can be reproduced from time to time when seeked to the end of the file. It happens as one thread declares that the file is ended and another thread declares the ending reason. If the file ended thread happens first the stop reason won't be set. My fix makes sure when the lastFrame is played the end reason will be set as STKAudioPlayerStopReasonEof
ruduss
reviewed
Feb 21, 2022
ruduss
left a comment
There was a problem hiding this comment.
Would it be best for us to do the additional check of STKAudioPlayerStopReasonNone in our code rather than make the change in STKAudioPlayer?
eg in FileAudioService the change could be:
@objc func audioPlayer(_ audioPlayer: STKAudioPlayer!, didFinishPlayingQueueItemId queueItemId: NSObject!,
with stopReason: STKAudioPlayerStopReason, andProgress progress: Double, andDuration duration: Double) {
if stopReason == STKAudioPlayerStopReasonEof || stopReason == STKAudioPlayerStopReasonNone {
self.audioCompletedSubject.onNext(())
}
}
Author
|
@ruduss I considered this option, the issue with
|
ruduss
approved these changes
Feb 21, 2022
harshapel
approved these changes
Feb 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At some cases an STKAudioPlayerStopReasonNone declared although the file reached the end. The issue can be reproduced from time to time when seeked to the end of the file.
It happens as one thread declares that the file is ended on
OutputRenderCallbackand another thread declares the ending reason on theprocessRunloop. If the file ended thread happens first the stop reason won't be set. My fix makes sure when the lastFrame is played the end reason will be set as STKAudioPlayerStopReasonEof