fix: use serde rename for generic field names and add comprehensive schema field path validation#34
Merged
Artifizer merged 4 commits intoGlobalTypeSystem:mainfrom Jan 8, 2026
Merged
Conversation
…chema field path validation Fixes issue where generic field names were using Rust field identifiers instead of the serialized name from #[serde(rename = "...")] attribute. Changes: - gts-macros/src/lib.rs: Use get_serde_rename() to get serialized field name for generic fields - gts-macros/tests/inheritance_tests.rs: Add comprehensive schema field path validation tests: - Tests for all nested schemas (BaseEventV1, AuditPayloadV1, PlaceOrderDataV1, etc.) - Tests for generic vs non-generic type nesting behavior - Test for serde rename on generic fields (ContainerV1 -> inner_data) - Tests for additionalProperties: false at correct nesting levels Signed-off-by: Artifizer <artifizer@gmail.com>
…atus Signed-off-by: Artifizer <artifizer@gmail.com>
Signed-off-by: Artifizer <artifizer@gmail.com>
…po if needed automatically Signed-off-by: Artifizer <artifizer@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: use serde rename for generic field names and add comprehensive schema field path validation
doc(README.md): Update checkboxes to reflect actual implementation status