More msvc improvements #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VLAs were giving CL.exe fits.
This folder should be automatically repopulated by vcpkg when building in MSVC.
Quipyowert2
added a commit
to Quipyowert2/glob2
that referenced
this pull request
May 10, 2023
In PR Globulation2#96, "snprintf & friends", I changed an ifdef near the line that was moved in patch Globulation2#3. That fixed an error with Visual Studio 2015 and later, but caused that patch to fail to apply in GitHub Actions PR Globulation2#77.
Quipyowert2
added a commit
to Quipyowert2/glob2
that referenced
this pull request
May 10, 2023
In PR Globulation2#96, "snprintf & friends", I changed an ifdef near the line that was moved in patch Globulation2#3. That fixed an error with Visual Studio 2015 and later, but caused the patch to fail to apply in GitHub Actions PR Globulation2#77.
Quipyowert2
added a commit
to Quipyowert2/glob2
that referenced
this pull request
May 10, 2023
In PR Globulation2#96, "snprintf & friends", I changed an #ifdef near the line that was moved in patch Globulation2#3. That fixed an error with Visual Studio 2015 and later, but caused the patch to fail to apply in GitHub Actions PR Globulation2#77.
Quipyowert2
added a commit
to Quipyowert2/glob2
that referenced
this pull request
May 10, 2023
In PR Globulation2#96, "snprintf & friends", I changed an #ifdef near the line that was moved in patch Globulation2#3. That change fixes an error with Visual Studio 2015 and later, but caused the patch to fail to apply in GitHub Actions PR Globulation2#77.
This was referenced May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request does the following:
valarrays to make it compile on Visual Studio.vcpkgduring compilation. This reduces the total changes listed in Git Changes by 90% from 8983 changes to 838 changes. The rest of the changes are Visual Studio / VSCode settings or my various build directories.