Add vertical scrolling for parameter list in TUI#100
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Gnarus-G
force-pushed
the
feature/68-tui-scrolling
branch
from
4711c3f to
e51d755
Compare
Allow users to scroll through parameters using page up/down keys by mapping them to dedicated Action variants. This enhances navigation smoothness and matches typical terminal UI expectations for paging. When content height changes dynamically, the scroll behavior adapts using calculated visible rows based on available space and margin. Updates to scroll logic ensure proper positioning when pages exceed visible area, maintaining user context during navigation. This change sets up foundation for proper scrollbars and improves accessibility by supporting keyboard-based pagination of parameters. <footer> </footer>
Use relative target/release path directly instead of constructing with pwd. This resolves issues when running from different directories and aligns with standard Makefile conventions for installed binaries.
- Create CustomScrollbar widget in tui/src/widgets/scrollbar.rs - Replace ratatui's built-in Scrollbar with custom implementation - Calculate thumb position using precise float math to ensure thumb reaches bottom when viewing last parameters - Add scrollbar to tui/src/widgets/mod.rs and lib.rs - Update screen.rs to use the new CustomScrollbar widget
Gnarus-G
force-pushed
the
feature/68-tui-scrolling
branch
from
e51d755 to
f96e1b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements vertical scrolling for the parameter input widget when parameters overflow the visible area. Uses ratatui's Scrollbar widget with mouse wheel support.
Features:
Closes #68