Skip to content

chore: bump plugin manifests to v5.2.0#22

Merged
intel352 merged 1 commit into
mainfrom
chore/bump-v5.2.0
Apr 25, 2026
Merged

chore: bump plugin manifests to v5.2.0#22
intel352 merged 1 commit into
mainfrom
chore/bump-v5.2.0

Conversation

@intel352
Copy link
Copy Markdown
Contributor

Picks up the reviewer-prompt tightening from PR #21 (merged).

Changes

  • .claude-plugin/plugin.json: 5.1.0 → 5.2.0
  • .claude-plugin/marketplace.json: 5.1.0 → 5.2.0

What's in v5.2.0

subagent-driven-development reviewer prompts

  • Inlined four-step / five-step required workflows so reviewers actually apply the bug-class checklist + run-the-tests-yourself discipline on every dispatch (rather than only once at agent spawn)
  • Range-diff guidance for multi-commit tasks (git diff <base>..<head>)
  • Project-appropriate test invocations (no hard-coded -tags=e2e)
  • DM-routing rule explicit: DM the implementer who CURRENTLY OWNS the task per TaskList, not whoever sent the most recent message
  • Bookkeeping rule: code-reviewer marks BOTH the "Review quality:" AND the corresponding "Implement:" task completed (canonical workflow + prompt template now consistent)

requesting-code-review/SKILL.md — three new bug classes

  • Test hermeticity / non-determinism — real network/DB/fs/clock dependencies in tests; promote to Important even if the test passes today
  • Cross-platform / portability/ path literals, bash-only shell, Unix-only env vars (with note that PATH exists on Windows)
  • Vacuous assertion — distinguishes (a) syntactic tautology (err == nil || err != nil) from (b) trivially-satisfied-for-every-test-input (more common in field experience)

Field validation

Validated across 24 implementation tasks (Phase 1 + Phase 2 of the Core Runner companion-game scaffold for the Core Dump MMORPG):

  • 4 vacuous-assertion catches (would have shipped under the old rubric)
  • 3 error-swallowing catches (_ = err / unchecked Scan)
  • 1 test-hermeticity catch (test connecting to real localhost)
  • 1 cross-platform catch (Windows path-separator bug in HUD-file detector)
  • 2 cross-task cascade preemptions (cascade risks caught at one task's review and folded into the next task's spec before it began)
  • Code-reviewers now consistently cite actual go test / cargo test output on every approval

Compatibility

Additive only. No breaking changes to existing skill APIs. Existing subagent-driven-development consumers will see tighter reviews; existing requesting-code-review users get three additional bug classes to scan against.

🤖 Generated with Claude Code

Picks up the reviewer-prompt tightening from PR #21:

- Inlined four-step / five-step required workflows in the
  subagent-driven-development reviewer prompt templates so reviewers
  apply the bug-class checklist + run-the-tests-yourself discipline
  on every dispatch
- Three new bug classes in skills/requesting-code-review/SKILL.md:
  Test hermeticity / non-determinism, Cross-platform / portability,
  Vacuous assertion
- DM-routing rule (DM the implementer who currently OWNS the task)
  and bookkeeping rule (code-reviewer marks BOTH the Review-quality
  AND the Implement task completed) reconciled across SKILL.md and
  the prompt template
- Range-diff guidance for multi-commit tasks (`git diff <base>..<head>`)
- Project-appropriate test invocations (no hard-coded `-tags=e2e`)

Field-validated across 24 implementation tasks (Phase 1 + Phase 2 of
a Core Runner companion-game scaffold): 4 vacuous-assertion catches,
3 error-swallowing catches, 2 cross-task cascade preemptions, code-
reviewers consistently citing actual test-run output.

Additive only. No breaking changes to existing skill APIs.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings April 25, 2026 21:41
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Bumps the Claude plugin manifest versions to v5.2.0 so the marketplace and plugin metadata reflect the updated prompt/skill content shipped in the repository.

Changes:

  • Update .claude-plugin/plugin.json version from 5.1.0 to 5.2.0
  • Update .claude-plugin/marketplace.json version from 5.1.0 to 5.2.0

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.claude-plugin/plugin.json Updates plugin manifest version to 5.2.0.
.claude-plugin/marketplace.json Updates marketplace plugin entry version to 5.2.0.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@intel352 intel352 merged commit 8a90c94 into main Apr 25, 2026
8 checks passed
@intel352 intel352 deleted the chore/bump-v5.2.0 branch April 25, 2026 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants