Skip to content

Add PR lifecycle hooks: Copilot reviewer enforcement, monitoring reminder, and monitor agent tuning#25

Merged
intel352 merged 11 commits into
mainfrom
copilot/add-pr-monitoring-reminder-hook
May 6, 2026
Merged

Add PR lifecycle hooks: Copilot reviewer enforcement, monitoring reminder, and monitor agent tuning#25
intel352 merged 11 commits into
mainfrom
copilot/add-pr-monitoring-reminder-hook

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 1, 2026

  • hooks/pretool-pr-review-reminder: soften hook from blocking to reminder; quote "@copilot"
  • hooks/pretool-pr-review-reminder: switch reminder construction from string concatenation to heredoc
  • hooks/posttool-pr-created: only emit reminder when PR creation succeeded (pr_url non-empty)
  • skills/pr-monitoring/SKILL.md: add step to derive run-id from gh pr checks --json detailsUrl output before calling gh run view
  • skills/pr-monitoring/SKILL.md: add databaseId/url to GraphQL reviewThreads query + document REST reply-in-thread mechanism
  • skills/pr-monitoring/SKILL.md: after 3 failed revision rounds, leave thread unresolved and surface in timeout report (do NOT resolve)
  • skills/pr-monitoring/SKILL.md: fix Safety Limits table — "leave thread unresolved, surface in timeout report" instead of "resolve thread"
  • skills/pr-monitoring/SKILL.md: fix duplicate step label c. → d. in CI failure workflow steps
  • Tests pass

Copilot AI and others added 7 commits May 1, 2026 16:06
…, and finishing-a-development-branch

Agent-Logs-Url: https://github.com/GoCodeAlone/claude-superpowers/sessions/0819218d-f7ef-40c8-ae9a-7962ca512562

Co-authored-by: intel352 <77607+intel352@users.noreply.github.com>
Copilot AI self-assigned this May 1, 2026
Copilot AI review requested due to automatic review settings May 1, 2026 16:21
Copilot AI review requested due to automatic review settings May 1, 2026 16:21
Copilot AI requested review from Copilot and removed request for Copilot May 1, 2026 16:30
Copilot AI requested a review from intel352 May 1, 2026 16:31
@intel352 intel352 marked this pull request as ready for review May 1, 2026 22:42
Copilot AI review requested due to automatic review settings May 1, 2026 22:42
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds new GitHub CLI lifecycle hooks to nudge agents toward consistent PR hygiene (adding Copilot reviewer post-create and starting PR monitoring), and updates the pr-monitoring skill to better handle multi-PR sessions with lower GitHub API usage.

Changes:

  • Add a PreToolUse hook to inject a reminder about adding "@copilot" as a reviewer after gh pr create.
  • Add a PostToolUse hook to remind agents to start superpowers:pr-monitoring after gh pr create.
  • Update pr-monitoring guidance for multi-PR monitoring, worktree usage, and longer polling/session limits; align finishing-a-development-branch text accordingly.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
skills/pr-monitoring/SKILL.md Expands monitoring guidance to cover multi-PR sessions, worktrees, bot-thread handling, and a 60-min / 10-min polling cadence.
skills/finishing-a-development-branch/SKILL.md Adjusts autonomous-mode wording to prefer a single monitor agent for multiple PRs.
hooks/pretool-pr-review-reminder New PreToolUse reminder injected before gh pr create about adding "@copilot" reviewer post-creation.
hooks/posttool-pr-created New PostToolUse reminder injected after gh pr create to ensure superpowers:pr-monitoring is started.
hooks/hooks.json Registers the new PreToolUse and PostToolUse hooks for Bash tool calls.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread skills/pr-monitoring/SKILL.md Outdated
Comment thread skills/pr-monitoring/SKILL.md Outdated
Comment thread hooks/posttool-pr-created Outdated
Comment thread hooks/pretool-pr-review-reminder Outdated
Comment thread skills/pr-monitoring/SKILL.md Outdated
Comment thread skills/pr-monitoring/SKILL.md
@intel352
Copy link
Copy Markdown
Contributor

intel352 commented May 1, 2026

@copilot apply changes based on the comments in this thread

Copilot AI requested review from Copilot and removed request for Copilot May 1, 2026 22:52
Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 1, 2026

@copilot apply changes based on the comments in this thread

Applied all 6 changes from the review (commits 695dabf and 3c7eed2):

  • pretool-pr-review-reminder: replaced string concatenation with a heredoc for the reminder text
  • posttool-pr-created: gated the reminder on confirmed PR creation — exits silently if no PR URL is found in the tool response (i.e., gh pr create failed)
  • pr-monitoring/SKILL.md: added --json detailsUrl to gh pr checks and a step to extract the run ID from that URL before calling gh run view
  • pr-monitoring/SKILL.md: added databaseId and url fields to the GraphQL reviewThreads query, plus a documented REST in_reply_to_id call to post inline replies
  • pr-monitoring/SKILL.md: after 3 failed revision rounds, thread is left unresolved and surfaced in the timeout report instead of being force-resolved
  • pr-monitoring/SKILL.md: Safety Limits table updated to match; also fixed a duplicate c. step label in the CI failure workflow

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread skills/pr-monitoring/SKILL.md Outdated
Comment thread skills/pr-monitoring/SKILL.md Outdated
Comment thread skills/pr-monitoring/SKILL.md Outdated
Comment thread hooks/pretool-pr-review-reminder Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Comment thread hooks/pretool-pr-review-reminder Outdated
Comment thread skills/pr-monitoring/SKILL.md Outdated
Comment thread skills/pr-monitoring/SKILL.md Outdated
Copy link
Copy Markdown
Contributor

@intel352 intel352 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved after checks passed and addressed review threads were resolved.

@intel352 intel352 merged commit 173d58b into main May 6, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants