Skip to content

fix(requesting-code-review): correct fixture line refs (post-merge Copilot finding) #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
intel352 merged 1 commit into from
Apr 25, 2026
Merged

fix(requesting-code-review): correct fixture line refs (post-merge Copilot finding) #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...s/requesting-code-review/test-fixtures/sibling-asymmetry/expected-new-result.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ No MISSING items. No SCOPE CREEP.

## Bug-class scan

**Symmetry violations** — FINDING. `Inspect` omits `"kind": d.kind`. Both `Create` (line 11) and `Delete` (line 26) set it as the first arg in their maps. (See Finding 1 below.)
**Symmetry violations** — FINDING. `Inspect` omits `"kind": d.kind`. Both `Create` (line 12) and `Delete` (line 27) set it as the first arg in their maps. (See Finding 1 below.)

**Checks completed without further findings:**

Expand All @@ -27,8 +27,8 @@ No MISSING items. No SCOPE CREEP.
### Finding 1 — Inspect omits `kind` arg present in all sibling methods
- **Severity**: Important
- **Bug class**: Symmetry violations
- **Location**: `lib/dispatcher.go:17`
- **What's wrong**: The new `Inspect` method's args map omits `"kind": d.kind`. Sibling methods `Create` (line 11) and `Delete` (line 26) both set it as the first key.
- **Location**: `lib/dispatcher.go:18`
- **What's wrong**: The new `Inspect` method's args map omits `"kind": d.kind`. Sibling methods `Create` (line 12) and `Delete` (line 27) both set it as the first key.
- **Why it matters**: Receivers downstream rely on `kind` to dispatch correctly. Calling `Inspect` will silently target the wrong dispatch path or return `not found` because the receiver cannot disambiguate the request type.
- **Suggested fix**: Add `"kind": d.kind,` as the first key in the args map, matching siblings.

Expand Down
Loading