fix: admin-merge wfctl update PRs#3
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the update-wfctl GitHub Actions workflow to better manage and finalize automated wfctl formula update pull requests when repo auto-merge is disabled, including using a higher-privilege token when available and performing an admin merge after checks/reviews are clean.
Changes:
- Use
secrets.RELEASES_TOKEN(when present) asGH_TOKENfor PR management operations. - Request Copilot review on the generated update PR.
- Poll PR checks and unresolved review threads, then admin-merge once conditions are clean.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+154
to
+159
| failed="$(jq '[.[] | select(.bucket == "fail")] | length' <<< "$checks")" | ||
| pending="$(jq '[.[] | select(.bucket == "pending")] | length' <<< "$checks")" | ||
| if [ "$failed" != "0" ]; then | ||
| jq -r '.[] | select(.bucket == "fail") | [.name,.state,.link] | @tsv' <<< "$checks" | ||
| exit 1 | ||
| fi |
Comment on lines
+179
to
+180
| gh pr merge "$PR_NUMBER" --squash --admin --delete-branch | ||
| exit 0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Follow-up to homebrew-tap PR #2: repo auto-merge is disabled, so the previous --auto attempt could leave generated formula update PRs open.