Fix Go version compatibility issues in examples CI workflow#17
Merged
Fix Go version compatibility issues in examples CI workflow#17
Conversation
Co-authored-by: intel352 <77607+intel352@users.noreply.github.com>
Co-authored-by: intel352 <77607+intel352@users.noreply.github.com>
Co-authored-by: intel352 <77607+intel352@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix examples
Fix Go version compatibility issues in examples CI workflow
Jun 28, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Copilot AI
added a commit
that referenced
this pull request
Aug 24, 2025
…17) * Initial plan * Debug service dependency injection: Constructor called but httpclient service missing Co-authored-by: intel352 <77607+intel352@users.noreply.github.com> * Fix reverseproxy httpclient service resolution and enable verbose logging demo Co-authored-by: intel352 <77607+intel352@users.noreply.github.com> * Add interface-based service dependency resolution with comprehensive tests Co-authored-by: intel352 <77607+intel352@users.noreply.github.com> * Simplify service dependency resolution by removing duplicate http-doer service and integration module Co-authored-by: intel352 <77607+intel352@users.noreply.github.com> * Fix major linter issues and test failures in httpclient and reverseproxy modules Co-authored-by: intel352 <77607+intel352@users.noreply.github.com> * Fix all remaining linter errors and maintain passing tests Co-authored-by: intel352 <77607+intel352@users.noreply.github.com> * Fix reverseproxy module test failure by removing featureFlagEvaluator dependency Co-authored-by: intel352 <77607+intel352@users.noreply.github.com> * Address review feedback: restore featureFlagEvaluator, simplify httpclient matching, remove custom httpDoer interface Co-authored-by: intel352 <77607+intel352@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: intel352 <77607+intel352@users.noreply.github.com> Co-authored-by: Jonathan Langevin <jlangevin@crisistextline.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The examples CI workflow was failing with errors like:
Root Cause
Version incompatibility between the CI environment and example modules:
^1.23.51.24.2in theirgo.modfiles1.23.0This mismatch caused build failures when the CI tried to build examples with newer Go syntax/features using an older Go version.
Solution
Updated all examples to use consistent Go version:
Before:
After:
Changes Made
go.modfiles in all examples to use Go1.23.0(matching main module)toolchaindirectives that were causing conflictsgo mod tidyto clean up dependenciesExamples Fixed
✅ basic-app: Builds, starts correctly, health endpoint responds
✅ advanced-logging: Builds, starts correctly, HTTP client logging works
✅ reverse-proxy: Builds, starts correctly with multi-tenant configuration
✅ http-client: Builds, starts correctly
✅ multi-tenant-app: Builds, starts correctly with tenant management
Verification
GOWORK=off go build .The CI workflow should now pass without version compatibility issues.
Fixes #16.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
httpbin.org./advanced-logging(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.