fix: release workflow goreleaser --skip=validate — accept ui_dist drift at release time#18
Merged
Merged
Conversation
…ft at release time
v1.0.3 release run surfaced third bug after npm-auth + cp-cwd fixes landed:
release failed after 0s
error= git is in a dirty state
M internal/ui_dist/index.html
Root cause: Build-admin-UI step rebuilds internal/ui_dist/ from workflow
repo HEAD (latest UI source), which may differ from this repo's committed
snapshot (kept in-tree for go:embed at dev time). GoReleaser's
git-dirty-state validation correctly flags this as 'modified files since
last commit'.
The fresh build IS the intended release artifact — we WANT the just-built
dist embedded in the release binary, not the stale committed snapshot. So
the dirty state is expected at release time.
Fix: --skip=validate flag bypasses dirty check. Per goreleaser docs this
is the appropriate escape hatch when build artifacts intentionally differ
from committed state.
Followup: cut v1.0.4 from main after this lands.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Adds --skip=validate to the GoReleaser invocation in the release workflow so the freshly-rebuilt internal/ui_dist/ assets don't trip GoReleaser's git-dirty-state check during release.
Changes:
- Pass
--skip=validatetogoreleaser release --clean. - Add an inline comment explaining why the dirty-state check is bypassed (ui_dist is rebuilt from upstream UI repo HEAD at release time).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced May 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to PRs #14 + #16. v1.0.3 release run surfaced third bug after npm-auth + cp-cwd fixes landed: GoReleaser dirty-state check fires on freshly built ui_dist. Fix: --skip=validate. Followup: tag v1.0.4 from main.
🤖 Generated with Claude Code