fix: release workflow registry-sync step non-blocking — matches azure precedent#21
Merged
Merged
Conversation
… precedent v1.0.4 + v1.1.2 release runs were marked failure solely on the 'Update registry manifest' step failing with: remote: Invalid username or token. Password authentication is not supported for Git operations. fatal: Authentication failed for 'https://github.com/GoCodeAlone/workflow-registry.git/' Root cause: `secrets.REGISTRY_PAT` is not set on this repo. The registry manifest sync is INFORMATIONAL — the release itself was published before this step ran. Failure here marks the overall run as failed but doesn't affect the released artifacts. Fix: add `continue-on-error: true` to the registry-sync step. Matches the workflow-plugin-azure release.yml pattern (verified 2026-05-16). Proper fix is for the operator to add REGISTRY_PAT secret to this repo; this PR is the stopgap so release runs don't show red on a non-blocking informational step. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Makes the release workflow's registry-sync step non-blocking so that a missing REGISTRY_PAT secret no longer fails the overall release run, matching the precedent set by workflow-plugin-azure.
Changes:
- Add
continue-on-error: trueto the "Update registry manifest" step - Add comment explaining rationale and referencing the azure precedent
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v1.0.4 + v1.1.2 release runs were marked failure solely on registry-sync step (REGISTRY_PAT secret not set). Step is informational; release artifacts publish before this step. Fix: continue-on-error: true (matches azure release.yml pattern).
Proper fix is operator adding REGISTRY_PAT secret. This PR is the stopgap.
🤖 Generated with Claude Code