Skip to content

chore: apply plugin version discipline#38

Merged
intel352 merged 1 commit into
mainfrom
issue-760-version-discipline
Jun 1, 2026
Merged

chore: apply plugin version discipline#38
intel352 merged 1 commit into
mainfrom
issue-760-version-discipline

Conversation

@intel352
Copy link
Copy Markdown
Contributor

@intel352 intel352 commented Jun 1, 2026

Part of GoCodeAlone/workflow#760.

Changes:

  • keep committed plugin.json.version at the 0.0.0 development sentinel
  • add post-build release validation so the shipped manifest is checked against the tag

Verification:

  • wfctl plugin validate-contract .
  • wfctl plugin validate-contract --for-publish --tag v9.9.9 .
  • GOWORK=off go test ./...

Copilot AI review requested due to automatic review settings June 1, 2026 17:07
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Applies plugin version discipline by resetting the in-tree plugin.json to the 0.0.0 development sentinel (GoReleaser injects the real tag at release time) and adds a post-build verification step that re-runs wfctl plugin validate-contract --for-publish against the release artifacts to confirm the shipped manifest carries the tag.

Changes:

  • Reset plugin.json version to 0.0.0 sentinel.
  • Add post-build validate-contract step using --release-dir . in release.yml.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
plugin.json Version reset to 0.0.0 dev sentinel; tag is injected at release.
.github/workflows/release.yml New post-build step validates that shipped plugin.json carries the release tag.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@intel352 intel352 merged commit e06e9bf into main Jun 1, 2026
9 checks passed
@intel352 intel352 deleted the issue-760-version-discipline branch June 1, 2026 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants