Fix installer-compatible release archive names#40
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates GoReleaser’s release archive naming to be compatible with wfctl plugin install by switching archive name separators from underscores to hyphens, and adds a regression test to prevent the naming template from regressing.
Changes:
- Updated
.goreleaser.yamlarchivename_templateto use hyphens (-) instead of underscores (_). - Added
release_config_test.goto assert the expected archive naming template and disallow underscore-based templates.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
release_config_test.go |
Adds a regression test for the GoReleaser archive naming template (currently needs adjustment to avoid an external-test package build failure and to make the check less brittle). |
.goreleaser.yaml |
Switches the archive name_template from underscore-separated to hyphen-separated names for installer compatibility. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1
to
+5
| package admin_test | ||
|
|
||
| import ( | ||
| "os" | ||
| "strings" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests