-
Notifications
You must be signed in to change notification settings - Fork 0
Closed
Description
Summary
The plugin.json included in the v0.3.0 release tarball has "version": "1.0.0" instead of "version": "0.3.0":
{
"name": "workflow-plugin-authz",
"version": "1.0.0",
...
}This was also the case in v0.2.0 — the manifest has always said 1.0.0 regardless of the actual release tag.
Impact
- Consumers cannot programmatically verify they have the correct plugin version
wfctl plugin list(if/when implemented) would report the wrong version- Contradicts the Go module version (
v0.3.0) and the GitHub release tag
Suggested Fix
Update plugin.json to reflect the actual version, either:
- Manual: Update
"version"inplugin.jsonbefore each release - Automated: Use goreleaser's templating to inject the tag version into
plugin.jsonduring the release build:
# .goreleaser.yml
before:
hooks:
- cmd: sed -i 's/"version": ".*"/"version": "{{ .Version }}"/' plugin.jsonOption 2 ensures the manifest always matches the release tag without manual steps.
Reactions are currently unavailable