docs: add post-merge retro for typed-IaC conformance (issue #8)#12
Merged
Conversation
intel352
added a commit
that referenced
this pull request
May 17, 2026
Addresses Copilot findings on the workflow_dispatch escape-hatch PR: - Add explicit tag regex validation (^vN.N.N(-suffix)?$) before any shell/Python interpolation — addresses 3 shell-injection inlines raised by Copilot across the 4 plugin PRs (gcp #12 line 26, DO #122 lines 29 + 43, aws #19 line 26). - DO only: restore the downloads[*].url update block that the prior push clobbered. DO has a regression-gate test TestSyncPluginVersionWorkflowUpdatesDownloads asserting the python block updates dl['url'] per release tag. - aws/gcp/azure: NOT adding downloads-update because their goreleaser binary naming convention differs (`{name}_{version}_{goos}_{goarch}` vs DO's `{name}-{goos}-{goarch}`) — would create broken URLs. The downloads[] staleness is cosmetic; workflow-registry has authoritative download URLs.
intel352
added a commit
that referenced
this pull request
May 17, 2026
* ci: add workflow_dispatch escape hatch to sync-plugin-version.yml Defensive fix for the failure mode surfaced by workflow-plugin-aws#18: sync-plugin-version.yml did not fire on a v1.2.0 tag push despite the matching `tags: ['v*']` trigger that worked on v1.1.0. Root cause was not identified (likely transient GitHub Actions backend hiccup); the workaround was a manual one-line plugin.json sync PR. This change adds a workflow_dispatch trigger taking a tag input so the sync workflow can be manually re-fired when the push-tag trigger silently no-ops. The same patch is being applied across all 4 IaC plugin repos (aws/gcp/azure/digitalocean) since they share the workflow file pattern. The push-tag trigger path is unchanged; the manual dispatch path uses `inputs.tag` and falls back to `github.ref_name` otherwise via the `inputs.tag || github.ref_name` expression. Closes workflow-plugin-aws#18 (defensive fix; no root cause identified). * ci: add tag-format validation + restore downloads-update (DO only) Addresses Copilot findings on the workflow_dispatch escape-hatch PR: - Add explicit tag regex validation (^vN.N.N(-suffix)?$) before any shell/Python interpolation — addresses 3 shell-injection inlines raised by Copilot across the 4 plugin PRs (gcp #12 line 26, DO #122 lines 29 + 43, aws #19 line 26). - DO only: restore the downloads[*].url update block that the prior push clobbered. DO has a regression-gate test TestSyncPluginVersionWorkflowUpdatesDownloads asserting the python block updates dl['url'] per release tag. - aws/gcp/azure: NOT adding downloads-update because their goreleaser binary naming convention differs (`{name}_{version}_{goos}_{goarch}` vs DO's `{name}-{goos}-{goarch}`) — would create broken URLs. The downloads[] staleness is cosmetic; workflow-registry has authoritative download URLs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/retros/2026-05-13-typed-iac-conformance-retro.mdfor PR feat: typed-IaC conformance migration to v1.0.0 (issue #8) #11 (feat: typed-IaC conformance migration to v1.0.0)host_conformance_test.go) and 2 missed skill activations (requesting-code-review,runtime-launch-validation)This is a docs-only commit; no code changes.
🤖 Generated with Claude Code