fix(provider): implement IaCProvider.{BootstrapStateBackend,SupportedCanonicalKeys} stubs#4
Merged
Merged
Conversation
…CanonicalKeys} stubs — closes pre-existing gap from workflow#499 Adds the two missing IaCProvider methods that were introduced upstream after this plugin's last workflow dep bump: - `BootstrapStateBackend(ctx, cfg) (*BootstrapResult, error)` — returns (nil, nil) per the interface's documented contract for providers that do not manage a state backend. AWS state lives in S3 via a separate workflow path. - `SupportedCanonicalKeys() []string` — returns the full `interfaces.CanonicalKeys()` set per the doc's "built-in and stub providers return the full canonical key set" guidance; per-driver field validation already happens in Diff. Bumps `github.com/GoCodeAlone/workflow` from v0.3.56 to v0.19.2 because the `interfaces.BootstrapResult` return type only exists in v0.18.6+. Without the dep bump, the BootstrapStateBackend method signature would not compile against the plugin's own CI. Surfaced by workflow PR #534's new cross-plugin-build CI gate, which builds this plugin against workflow main via a `replace` directive — exactly the gap class this gate was designed to catch. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Closes an IaCProvider interface gap introduced by newer workflow versions by adding the missing provider methods and updating module dependencies so this plugin builds against workflow main (and newer tagged releases).
Changes:
- Implement
AWSProvider.SupportedCanonicalKeys()by returninginterfaces.CanonicalKeys(). - Implement
AWSProvider.BootstrapStateBackend(...)as a documented no-op returning(nil, nil). - Bump
github.com/GoCodeAlone/workflowtov0.19.2(and refresh transitive deps viago mod tidy).
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| provider/provider.go | Adds SupportedCanonicalKeys and BootstrapStateBackend to satisfy the updated interfaces.IaCProvider contract. |
| go.mod | Upgrades workflow dependency (plus associated direct/indirect module version updates). |
| go.sum | Updated checksums reflecting the dependency upgrades and tidied module graph. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
… params - Replaced multi-cloud "S3/GCS/Azure Blob" doc copy with AWS-specific reference. - SupportedCanonicalKeys doc no longer claims per-driver Diff validation (drivers compare overlapping fields; do not reject unsupported keys). - BootstrapStateBackend params switched to _ per repo's no-op convention. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the pre-existing IaCProvider interface gap surfaced by workflow PR #534's new cross-plugin-build CI gate. That gate builds this plugin against workflow
mainvia areplacedirective, which is exactly the gap class it was designed to catch.Changes
BootstrapStateBackend(ctx, cfg) (*BootstrapResult, error)return nil, nilSupportedCanonicalKeys() []stringreturn interfaces.CanonicalKeys()Diff.Dep bump
Bumps
github.com/GoCodeAlone/workflowfrom v0.3.56 → v0.19.2. Required becauseinterfaces.BootstrapResult(the return type) only exists in v0.18.6+. Without the bump, the method signature would not compile against the plugin's own CI.The bump is the minimum required to get both interface methods + the
BootstrapResulttype. No other intentional behavior changes;go mod tidypulled the standard transitive set.Sister-PR context
This is the second of three sister PRs closing the same gap class:
DO already implements both methods (real
BootstrapStateBackendfor Spaces).Test plan
GOWORK=off go build ./...cleanGOWORK=off go test ./...pass (provider + drivers)awsmatrix entry